botbowl icon indicating copy to clipboard operation
botbowl copied to clipboard

Published 20 hours ago • verified publisher icon njustesen

improve get_custom_game_turn() + fix broken tests

Open mrbermell opened this issue 2 years ago • 2 comments

Edit: Added description below.

This PR improves

  • tests.utils.get_custom_game_turn() by adding option to specify board size, turn. Also readability refactor.
  • test.utils.get_custom_turn() by adding option to specify board size

It also fixes some tests that broke because of this change (the test were dependent on initial setup formation which I had to change to accommodate all board sizes).

mrbermell avatar Apr 04 '22 10:04 mrbermell

Seems good and I think you already explained to me how this is an improvement. Can you remind me by adding a line or two to the PR?

Description added. Sorry, I was in a hurry when I added it.

mrbermell avatar Apr 08 '22 20:04 mrbermell

I'll wait with merging this until #234 is merged. Because the github action workflow broke and #234 fixes that.

mrbermell avatar May 17 '22 20:05 mrbermell