Nicholas Tierney
Nicholas Tierney
another option could be to use something like `https://github.com/const-ae/ggupset` instead - or document how to use both approaches, UpSetR and ggupset
Hello! Thank you very much for the kind words :) I'm glad to hear that you are using the special missings feature, and this is a great point that there...
Thank you!
If this helps, here is the current time comparison for haversines distances for geodist and the distance functions in maxcovr, [`distance_matrix_cpp`](https://github.com/njtierney/maxcovr/blob/d5f80512a441328e31ea8e532c9114f17cfd8dde/src/distanceHelpers.cpp#L65), which calls [`spherical_distance_cpp`](https://github.com/njtierney/maxcovr/blob/d5f80512a441328e31ea8e532c9114f17cfd8dde/src/distanceHelpers.cpp#L224) under the hood ``` r library(geodist)...
Thanks for sharing @mkuehn10 ! I'll point to another thread I wrote about here: https://github.com/njtierney/maxcovr/issues/20
I think that the extra gains are worthwhile since they scale well - but perhaps it should be tested in either 1. another branch, or 2. a separate package. The...
I guess the only other thing I can think of re performance is if there might be any gain in writing it in _fortran_ - but from what I understand...
OK sure thing, perhaps the `Imports: p5` line should be removed from the DESCRIPTION? I couldn't install the package with `devtools::install()` without the p5 library.
Actually would ```r renv::hydrate() ``` Just do this?
That would be amazing!