hbmqtt icon indicating copy to clipboard operation
hbmqtt copied to clipboard

Added client support for self signed certificate on MQTT server

Open Sjd-Risca opened this issue 4 years ago • 3 comments

I'd like to use the mqtt client against a server with a self signed Certificate Authority. The proposed patch will add a new client configuration attribute defined as ca_certs for assigning a custom CA (instead of using the system ones) to the ssl context. The connection will be initiated only if the mqtt server's certificate chain resolved to any of the custom CAs.

For reference, see the implementation from patho-mqtt: https://github.com/eclipse/paho.mqtt.python/blob/225ab3757f6818ba85eb80564948d1c787190cba/src/paho/mqtt/client.py#L767

Sjd-Risca avatar Jan 13 '21 14:01 Sjd-Risca

Nice! Can you think of a unit test for this feature? Maybe creating a tempfile and a certificate and loading that? I mean your changes use external logic, thus nothing should go wrong here. But it comes very handy when adding functionality.

HerrMuellerluedenscheid avatar Jan 20 '21 11:01 HerrMuellerluedenscheid

Hi @Sjd-Risca

hbmqtt has been deprecated by it's author. We created a fork here: https://github.com/Yakifo/amqtt

I like this change and would like to include it in our fork.

Would you be interested to create your MR there as well?

Thanks :)

FlorianLudwig avatar Mar 14 '21 12:03 FlorianLudwig

@HerrMuellerluedenscheid would you be interested in carrying this forward?

FlorianLudwig avatar Apr 03 '21 20:04 FlorianLudwig