hbmqtt
hbmqtt copied to clipboard
njouanin
WIP: refactor to comply python3.8 and python3.9
Great to see, that someone's working on a compatible version for Python versions >3.8. Any updates regarding this PR?
I'm on vacation til the end of the week and will hopefully find the time to look into this next week. A few additional errors were raised within the unit test which I need to have a closer look at.
Hey, just curious.. I'm eagerly waiting for this PR to be merged.. Is the PR ready to be merged?? Thanks
It's not ready, yet. The tests do not succeed yet because of previously introduced hiccups that need to be resolved on master beforehand, I guess.
Tests pass for python 3.6, 3.7, 3.8 and 3.9 after reverting as discussed in #231. https://travis-ci.org/github/beerfactory/hbmqtt/builds/753846602. Still, I would like to have #231 resolved to build on solid grounds.
Hey @HerrMuellerluedenscheid is this PR ready to be merged? I saw your other PR's (#228, #229) and Issue (#235) & I don't think @njouanin is ready to act on those..
If this PR is ready I would like to merge this into my own Fork.. Thanks.
Hey @HerrMuellerluedenscheid is this PR ready to be merged? I saw your other PR's (#228, #229) and Issue (#235) & I don't think @njouanin is ready to act on those..
If this PR is ready I would like to merge this into my own Fork.. Thanks.
Hey @pavandv , No, it's not ready. I mean tests pass but I reverted a commit by @shipmints in this MR just to get the CI running. Thus, this MR now additionally depends on #236 to restore what @shipmints fixed. We need feedback/approval/merge by @njouanin.
Hey @HerrMuellerluedenscheid as this is not maintained anymore, what is the status on this??
@pavandv hey,
i continued the branch there: https://github.com/Yakifo/aio-hbmqtt/pull/18
it does not contain changes compared to this branch for the actual code, just tests.
