nix
nix copied to clipboard
nix-rust
Enable fcntl OFD commands on macos
What does this PR do
See title. Also note I'm waiting on the constants to be exposed in libc, see https://github.com/rust-lang/libc/pull/3563. When those are added I'll adjust the libc deps in Cargo.toml to match.
Checklist:
- [x] I have read
CONTRIBUTING.md - [x] I have written necessary tests and rustdoc comments
- [x] A change log has been added if this PR modifies nix's API
Hi, thanks for your interest in contributing to Nix!
If you want to bump the MSRV, I think this should be done in a separate PR, and you should also update this info in:
.cirrus.ymlREADME.md
And, for changes (logic changes and clippy fixes) requested by a newer version libc, I also recommend doing them in a separate PR.
Nix uses squash merge so multiple commits in a PR would be treated as a single commit
I'll follow this up when the libc PR goes through, as it depends heavily on that. Also there are some issues in using 64bit apis on 32bit systems with nix which requires that I work around it for now.
Feel free to run this to completion. I might revisit it when the libc stuff is merged. I have stopped depending on nix in the meanwhile as it deviates too much from libc.
it deviates too much from libc
You mean those libc breaking changes? They only exist in branch main, which targets libc version 1.0, we are still using branch libc-0.2 and won't switch to 1.0 in the near future.
I that why I was having trouble? Am I trying to use nix with the wrong branch of libc?
I that why I was having trouble? Am I trying to use nix with the wrong branch of libc?
I am not sure about the trouble you have, but if you want to use libc, you can use the one re-exported by Nix, which is guaranteed to be compatible with Nix.