nix icon indicating copy to clipboard operation
nix copied to clipboard

api inconsistency Epoll::modify and Epoll::add

Open dimbleby opened this issue 1 year ago • 2 comments

Epoll::add takes mut event: EpollEvent, whereas Epoll::modify takes event: &mut EpollEvent

seems like an odd difference, am I missing a reason that this is sensible?

dimbleby avatar Aug 28 '23 11:08 dimbleby

#1882, cc @JonathanWoollett-Light

dimbleby avatar Aug 28 '23 11:08 dimbleby

There is no strong reason.

Epoll::add could takes &mut EpollEvent,it may make sense to make a PR for this.

JonathanWoollett-Light avatar Aug 28 '23 12:08 JonathanWoollett-Light