nix icon indicating copy to clipboard operation
nix copied to clipboard

Extend type of service/traffic class socket options

Open spencercw opened this issue 2 years ago • 4 comments
trafficstars

spencercw avatar Jul 18 '23 08:07 spencercw

This looks good, but would it be possible to add a test?

asomers avatar Aug 06 '23 20:08 asomers

Added tests and rebased on master. The Linux aarch64 failure seems to be a transient network error.

spencercw avatar Aug 14 '23 10:08 spencercw

Hi, sorry for the late reply.

Something at Nix has changed so that this PR needs an update:

  1. We switched to a new mode for adding changelogs to avoid conflicts, please see CONTRIBUTING.md on how to do it

  2. Now we prefer cfg alias to avoid big cfg chunks, please see CONVENTIONS.md

    For example, the following code can be simplified to:

    #[cfg(any(
        target_os = "android",
        target_os = "freebsd",
        target_os = "ios",
        target_os = "linux",
        target_os = "macos",
        target_os = "netbsd",
        target_os = "openbsd",
    ))]
    
    #[cfg(any(linux_android, netbsdlike, target_os = "freebsd", target_os = "ios", target_os = "macos"))]
    

SteveLauC avatar Nov 29 '23 02:11 SteveLauC

Thanks for reviewing. Changes applied.

spencercw avatar Dec 04 '23 15:12 spencercw