nix icon indicating copy to clipboard operation
nix copied to clipboard

Published 20 hours ago • verified publisher icon nix-rust

Add support for LoongArch64

Open donmor opened this issue 1 year ago • 4 comments

Yet another architecture :-) I don' know much about rust, but at least it built on qemu <:-/

donmor avatar Apr 17 '23 03:04 donmor

Hi @donmor

Thanks for your contribution for LoongArch!

WARNING: The requested image's platform (linux/loong64) does not match the detected host platform (linux/amd64) and no specific platform was requested
exec /usr/sbin/sh: exec format error

Does it need to cross compile for loongarch64 target on x86_64 host?

Thanks, Leslie Zhai

xiangzhai avatar Apr 19 '23 05:04 xiangzhai

Hi @donmor

Thanks for your contribution for LoongArch!

WARNING: The requested image's platform (linux/loong64) does not match the detected host platform (linux/amd64) and no specific platform was requested
exec /usr/sbin/sh: exec format error

Does it need to cross compile for loongarch64 target on x86_64 host?

Thanks, Leslie Zhai

I think so but I failed to make it pass CI. I can build this locally on qemu vm, though <:-/

donmor avatar Apr 19 '23 12:04 donmor

And I'm not sure if it is finely optimized. It's just a simpliest patch to build this package on loongarch.

donmor avatar Apr 19 '23 12:04 donmor

Could we skip CI and just add basic support like ioctl for now? We can add CI at a later time, such as when promoting to Tier 2.

heiher avatar May 22 '23 12:05 heiher

loongarch64 is already in tier2. This PR should get more attention. @asomers would you like to take a look?

chenx97 avatar Jul 20 '24 14:07 chenx97

loongarch64 is already in tier2. This PR should get more attention. @asomers would you like to take a look?

Seconded. The user base of this architecture is definitely picking up and nix is an essential dependency for most Rust applications.

MingcongBai avatar Jul 20 '24 14:07 MingcongBai

The author of this PR hasn't been active on GitHub for a while, so feel free to pick it up.

SteveLauC avatar Jul 21 '24 01:07 SteveLauC

Triage: https://github.com/nix-rust/nix/pull/2045 (since nix 0.27.0) already contained the necessary ioctl change, so if this PR is to be rebased, only the CI changes will remain. nix is already working on LoongArch from 0.27.0 on, if one doesn't intend to hack on nix itself.

xen0n avatar Jul 21 '24 08:07 xen0n

Triage: #2045 (since nix 0.27.0) already contained the necessary ioctl change, so if this PR is to be rebased, only the CI changes will remain. nix is already working on LoongArch from 0.27.0 on, if one doesn't intend to hack on nix itself.

Thanks for confirming that!

so if this PR is to be rebased, only the CI changes will remain.

Please also add this target to the target support list of Nix as a tier2 target.

SteveLauC avatar Jul 21 '24 09:07 SteveLauC

Sorry for be inactive (I'm busy at work). I have this rebased here (#2461 ). I'm not sure if cirrus.yml is still necessary, so I'll leave this open but remove unnecessary changes.

donmor avatar Jul 21 '24 09:07 donmor

I'm not sure if cirrus.yml is still necessary, so I'll leave this open but remove unnecessary changes.

This is no longer needed, close it as superseded by #2461.

SteveLauC avatar Jul 21 '24 09:07 SteveLauC