nix
nix copied to clipboard
nix-rust
impl TryFrom<i32> for `nix::mman::MmapAdvise`
We have a use-case where we are intercepting the madvise syscall, and wish to handle certain types of advice specially. Without TryFrom, we need to write boilerplate to safely translate the application-provided i32 into a form nix::mman::madvise will take, and I'm not sure why madvise can't simply implement TryFrom itself?
(For what it's worth, I can't see how the failed check can possibly be related to this change?)
The CI failure was spurious, and I've restarted it. The change looks reasonable, but could you please add an entry to the CHANGELOG?
The CI failure was spurious, and I've restarted it. The change looks reasonable, but could you please add an entry to the CHANGELOG?
Done.
Friendly ping @acully-vmware, sorry for such a slow response, would you like to finish this PR?
You need to rebase your branch and adjust the location of the CHANGELOG entry (Put it under the new [Unreleased] - ReleaseDate ### Added section)
