nix icon indicating copy to clipboard operation
nix copied to clipboard

mount/linux: add a safe wrapper for open_tree(2)

Open lucab opened this issue 2 years ago • 6 comments

This adds an ergonomic wrapper for the Linux-specific open_tree(2) syscall, using safe-io file descriptors. The syscall has been introduced in kernel version 5.2 and allows FD-based manipulation of mount hierarchies.

lucab avatar Jan 06 '23 10:01 lucab

Mmh, it looks like the libc crate is missing some constants on Android and uclibc. I'll try to find some time to look into that.

lucab avatar Jan 06 '23 18:01 lucab

Ok, I landed several fixes in libc and now the CI here is green. This is ready for review.

lucab avatar Jan 22 '23 10:01 lucab

@rtzoeller @asomers may I ask for a review on this one?

lucab avatar Jan 30 '23 20:01 lucab

Sorry for such a slow response! And thanks for you work!

I have left some comments on this PR :)

SteveLauC avatar Oct 06 '23 08:10 SteveLauC

@SteveLauC thanks for the review! (And no need to apologise :blue_heart:) I've rebased against latest master and addressed the comments.

lucab avatar Oct 06 '23 14:10 lucab

Gentle on the author @lucab, would you like to finish this PR:)

SteveLauC avatar Dec 03 '23 03:12 SteveLauC