nix
nix copied to clipboard
nix-rust
add GETFPREGS and SETFPREGS ptrace calls
Added two new functions to the ptrace module: getfpregs and setfpregs gets and sets the floating point registers of the tracee.
This is based on #1426, but updated to the latest master.
Wow, totally forgot about this, thanks for picking it up :)
Looks like you have some minor formatting issue, otherwise it looks good. The issue is that the lines are sometimes too long; maybe the formatting options were changed since I wrote the code, or you maybe copied it into a block with higher indentation level? I'm not sure about the reason, but a cargo fmt should solve it.
Looks to my perspective that the build failure on macOS was transient; does anything else need to be done on the PR to move it forward? Maybe a rebuild will trigger some updated linter rules. In any case, I'd be happy to jump in if there's something needed.
@jasonk000 I've updated the CHANGELOG.md entry in the PR to move the entry I added to the current "Unreleased" section.
That has triggered a rebuild. I'll look to address any issues the linter passes identify, but it would be useful to get this integrated. Is there a person I should be interacting with to help move this PR forward?
(Edit: of note, @bmc-msft, the account which made the PR, is my work-specific account.)
@asomers is this a PR you can review for merging? If not you, can you point me in the right direction?
cc: @asomers again. Can this PR get reviewed? The previous PR, which this was based on was reviewed, but not merged in June of 2021. This would be helpful for multiple projects to get merged.