nix icon indicating copy to clipboard operation
nix copied to clipboard

Published 20 hours ago • verified publisher icon nix-rust

Is the Minver CI check actually working?

Open rtzoeller opened this issue 3 years ago • 1 comments
trafficstars

I noticed that Cargo.lock.msrv is currently listing an old version of libc which we can't possibly build with anymore (due to requiring new functions/constants)... it seems like the Minver CI check is not working correctly.

Do we need --locked? I'm guessing we're copying Cargo.lock.msrv to Cargo.lock and then promptly overwriting it with cargo check.

Or am I misunderstanding how this is intended to work?

rtzoeller avatar Aug 26 '22 01:08 rtzoeller

The Cargo.lock.msrv file is used to test the MSRV, not for Minver. It is working, although I think we can eliminate it now that our MSRV is 1.56.1 too. Minver is tested separately, using the nightly compiler.

asomers avatar Aug 26 '22 01:08 asomers