nix icon indicating copy to clipboard operation
nix copied to clipboard

Published 20 hours ago • verified publisher icon nix-rust

Workaround XNU bug in getifaddrs netmasks

Open roblabla opened this issue 1 year ago • 4 comments

Fixes #1709

roblabla avatar Aug 10 '22 14:08 roblabla

CI breakage seems unrelated to my MR (looks like the latest serde release broke compatibility with the version of rustc/cargo used by CI).

roblabla avatar Aug 10 '22 15:08 roblabla

CI breakage seems unrelated to my MR (looks like the latest serde release broke compatibility with the version of rustc/cargo used by CI).

The CI breakage was due to a Cargo bug that has since been fixed. However, serde needs to yank their most recent release and publish a new one before things will work again. https://github.com/serde-rs/serde/issues/2255 .

asomers avatar Aug 11 '22 02:08 asomers

Rebasing will fix ci

asomers avatar Aug 12 '22 00:08 asomers

I rewrote the workaround to be safer - at least, I think it's safer. It now copies the data to a new zeroed sockaddr_storage.

roblabla avatar Sep 07 '22 11:09 roblabla

Bump. This has been used in prod for a little while, and is, as far as I can tell, sound.

roblabla avatar Oct 20 '22 08:10 roblabla

@roblabla you still need to rebase this, both to fix CI and to fix the conflict.

asomers avatar Nov 19 '22 21:11 asomers

Looks good, but still needs a CHANGELOG entry.

asomers avatar Nov 20 '22 15:11 asomers

Build succeeded:

bors[bot] avatar Nov 29 '22 04:11 bors[bot]