nix icon indicating copy to clipboard operation
nix copied to clipboard

add XFS_SUPER_NUMBER to nix::sys::statfs

Open MrCroxx opened this issue 3 years ago • 3 comments
trafficstars

Close #1742 .

MrCroxx avatar Jun 10 '22 07:06 MrCroxx

Seems xfs is not supported by linux musl and android. I'll fix it.

MrCroxx avatar Jun 10 '22 14:06 MrCroxx

Looks like you may need to submit a PR to rust-lang/libc first.

asomers avatar Jun 11 '22 00:06 asomers

Looks like you may need to submit a PR to rust-lang/libc first.

I'm not sure if XFS actually supports these targets. I will check it first.

MrCroxx avatar Jun 11 '22 06:06 MrCroxx

Looks like you may need to submit a PR to rust-lang/libc first.

I'm not sure if XFS actually supports these targets. I will check it first.

Seems that musl does not support this, Androiddoes have it but it is missing from libc

SteveLauC avatar Oct 05 '22 03:10 SteveLauC

Seems that musl does not support this, Androiddoes have it but it is missing from libc

Thanks for the information. I've forgotten this PR for a long time. I checked musl-libc and bionic-libc today and sent an issue to rust libc. See https://github.com/rust-lang/libc/issues/2948 .

MrCroxx avatar Oct 08 '22 08:10 MrCroxx

ℹ️ [Scheduling was delayed due to a concurrency limit on community tasks](https://cirrus-ci.org/faq/#are-there-any-limits)
ℹ️ [Consider upgrading to a $10/month plan to get 2x the limits on any public and private repository](https://github.com/marketplace/cirrus-ci/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW45OTI=#pricing-and-setup)

🤣

MrCroxx avatar Oct 10 '22 11:10 MrCroxx

@asomers Any plan to increase CI quota?

MrCroxx avatar Oct 11 '22 06:10 MrCroxx

CI looks recovered, try adding a new commit

SteveLauC avatar Oct 11 '22 06:10 SteveLauC

CI passed, PTAL. 🥰

MrCroxx avatar Oct 11 '22 06:10 MrCroxx

@MrCroxx can you squash these changes down to a single commit? Changes look reasonable, thanks!

rtzoeller avatar Oct 13 '22 04:10 rtzoeller

@MrCroxx can you squash these changes down to a single commit? Changes look reasonable, thanks!

Sure.

MrCroxx avatar Oct 13 '22 04:10 MrCroxx