nix icon indicating copy to clipboard operation
nix copied to clipboard

Published 20 hours ago • verified publisher icon nix-rust

Add support for loongarch64

Open zhangwenlong8911 opened this issue 3 years ago • 2 comments

zhangwenlong8911 avatar Jun 08 '22 02:06 zhangwenlong8911

It's difficult for the nix maintainers to validate changes for platforms which are not supported by rustc, including ensuring they don't immediately regress in support as part of other changes. I see that there is a PR up adding support to rustc for loongarch64-unknown-linux-gnu; this change is likely gated on that PR and until loongarch64-unknown-linux-gnu is supported as at least a Tier 3 target by the Rust compiler.

Once loongarch64-unknown-linux-gnu is supported as a Tier 3 target by rustc, I'd like to see it added to our CI pipeline as part of this PR, so we can ensure the support doesn't regress. #1603 is a good example of the changes needed. Note that it'd be added to the Tier 3 section of README.md, not Tier 1.

thank you very much for your suggestion, I have moved loongarch64-unknown-linux-gnu to the Tier 3 section of README.md

zhangwenlong8911 avatar Jun 13 '22 01:06 zhangwenlong8911

It's difficult for the nix maintainers to validate changes for platforms which are not supported by rustc, including ensuring they don't immediately regress in support as part of other changes. I see that there is a PR up adding support to rustc for loongarch64-unknown-linux-gnu; this change is likely gated on that PR and until loongarch64-unknown-linux-gnu is supported as at least a Tier 3 target by the Rust compiler. Once loongarch64-unknown-linux-gnu is supported as a Tier 3 target by rustc, I'd like to see it added to our CI pipeline as part of this PR, so we can ensure the support doesn't regress. #1603 is a good example of the changes needed. Note that it'd be added to the Tier 3 section of README.md, not Tier 1.

thank you very much for your suggestion, I have moved loongarch64-unknown-linux-gnu to the Tier 3 section of README.md

We will use loongarch64-unknown-linux-gnuf64 as the target name (see https://github.com/rust-lang/rust/pull/96971). AFAIK rustc doesn't have any "alias" support for target names so we can't use a plain loongarch64-unknown-linux-gnu.

xry111 avatar Jun 15 '22 13:06 xry111

And please just wait until rust-lang/rust#96971 is merged and released, otherwise the code here would be still useless at best, or require further changes if things change at the Rust side.

Thans for your review, i just rebase the code, I whill wait until https://github.com/rust-lang/rust/pull/96971 is merged and released

zhangwenlong8911 avatar Nov 08 '22 12:11 zhangwenlong8911

Ah, so an equivalent change was already merged in #2045. This can be safely closed then.

xen0n avatar Aug 30 '23 18:08 xen0n