nix icon indicating copy to clipboard operation
nix copied to clipboard

Published 20 hours ago • verified publisher icon nix-rust

Add statx

Open vi opened this issue 3 years ago • 5 comments
trafficstars

Resolves #1649.

In current state this breaks the build for Musl targets.

vi avatar Feb 09 '22 21:02 vi

Hey @vi :) What is the status of this PR? I really hope this can be merged

I just tried it myself, sadly, there is a lot of missing stuff in libc.

SteveLauC avatar Oct 04 '22 23:10 SteveLauC

What is the status of this PR?

It is waiting for answers for questions:

  • What to do with the missing constants? Based on your pull request to libc, supposed answer is "wait for libc support", then "wait when nix starts depending on new libc".
  • Shall we get ahead of musl upstream and provide statx even on musl by using hacks?
  • Is overall design of the feature is OK and in line with nix? If code review comments e.g. about statx_without_path are resolved, and points above are resolved, will it be OK for merge or there will be just another round of problems?

vi avatar Oct 05 '22 06:10 vi

Shall we get ahead of musl upstream and provide statx even on musl by using hacks?

IMHO, this is not a good idea as musl hasn't provided a wrapper in their library. As I said in this comment, I would like to temporarily just support GNU/Linux.

SteveLauC avatar Oct 05 '22 06:10 SteveLauC

Is this waiting on any blockers, abandoned, or forgotten?

AppleSheeple avatar Dec 09 '24 01:12 AppleSheeple

@AppleSheeple , You can claim it if you want.

vi avatar Dec 09 '24 07:12 vi