stat fix unit tests for openbsd.

[devnexen]

trafficstars

[asomers]

What was the problems? Did these tests fail to compile, or fail at runtime?

[devnexen]

runtime failure (openbsd 7).

[asomers]

Well, the commit message is inaccurate then, because it doesn't "fix" the tests, it disables them. Are these functions not supported on OpenBSD? If so, we should remove the bindings for them. Or if it's just an issue with certain OpenBSD versions or something with the runtime config, then it would be appropriate to ignore the tests. That way they'll still be compiled, but won't be run by default.

[asomers]

The commit message is still pretty mysterious. What's the real problem?

[devnexen]

getting EPERM errnos for test_fstatat/mknod/mknodat, assertions failures test_stat_and_fstat/test_stat_and_lstat for example

[asomers]

Have you determined the root cause? Is it a bug in OpenBSD? If you simply ignore the failures without investigating, that might mask a bug in Nix. We wouldn't want that.

[devnexen]

it seems version related if I run an older version of openbsd the tests pass.

[asomers]

So is that a bug in OpenBSD then? It sounds worthy of investigation. Disabling tests just because they don't pass is a risky proposition.

[asomers]

@devnexen did you ever figure out the root cause of your failures?

[devnexen]

well I lost the VM in the meantime, will look after when I can.

[asomers]

I'm closing this for lack of activity. But if you ever do root-cause the issue, you can reopen it.