does not support sockaddr_in for libc::accept

[fzyzcjy]

trafficstars

Hi thanks for the lib! I find the accept does not allow us to know the struct sockaddr_in.

[asomers]

Could you describe your problem in more detail, please?

[fzyzcjy]

@asomers Looking at the nix doc and the linux doc, it seems that the nix's accept has one less effective argument, thus we cannot get info of sockaddr_in. Thanks!

[lk16]

Workaround

For people reading this in the future: I worked around it by calling getpeername() on the file descriptor.

We can prevent this call to getpeername() and I'll provide a PR if there's any possibility that it would get merged.

Description of the problem:

POSIX requires that the accept() function looks like this in C:

#include <sys/socket.h>

int accept(int socket, struct sockaddr *restrict address,
       socklen_t *restrict address_len);

So, in C, we can specify the file descriptor of the socket and get the address of the peer using the last two arguments.

Using Rust and Nix, we can't get the peer address, because Nix sends NULL pointers, which means the C library won't tell us the peer address.

Suggested change of signature

// current signature
pub fn accept(sockfd: RawFd) -> Result<RawFd>

// proposed signature
pub fn accept<T: SockaddrLike>(sockfd: RawFd) -> Result<(RawFd, T)>

We would keep the API consistent with getpeername(), getsockname() and recvfrom() which also live in the socket crate.

This change is not backwards compatible, but that seems unavoidable to me.