poetry2nix icon indicating copy to clipboard operation
poetry2nix copied to clipboard

what todo with recursion

Open patryk4815 opened this issue 7 months ago • 2 comments

poetry packages:

ipalib = "^4.10.2"
ipaclient = "^4.10.2"

Recursion in poetry.lock:

ipaclient -> ipalib -> ipaplatform -> ipapython -> ipaplatform -> ipapython -> ... recursion

What todo in that case? Manually should I modify poetry.lock and remove recursion?

ipaplatform depends on ipapython ipapython depends on ipaplatform

https://github.com/freeipa/freeipa/blob/master/ipaplatform/setup.py#L49 https://github.com/freeipa/freeipa/blob/master/ipapython/setup.py#L44

patryk4815 avatar Dec 29 '23 04:12 patryk4815

This is not really a Poetry2nix question, but more of a "How to package Python with Nix" question. This needs to be solved in nixpkgs.

See https://github.com/NixOS/nixpkgs/issues/272178 for more context regarding the nixpkgs architecture and a potential solution to circular dependencies.

adisbladis avatar Dec 29 '23 04:12 adisbladis

@adisbladis Poetry2nix can resolve circular dependencies by skipping them, and even if the installation in the virtual environment doesn't have a proper graph, it should still work fine.

Circular dependencies are typically required only at runtime, not during the build process. Thus, for poetry2nix.venv, skipping such dependencies should pose no issues.

Or I'm missing something?

why should we be concerned about having a one-to-one proper graph in this context?

patryk4815 avatar Dec 29 '23 05:12 patryk4815