nixvim icon indicating copy to clipboard operation
nixvim copied to clipboard

plugins/cord-nvim: init

Open Eveeifyeve opened this issue 1 year ago • 20 comments

Adds the cord-nvim plugin. For more info view the plugin homepage: https://github.com/vyfor/cord.nvim.

fixes: #2373

Note: It's work in progress as I need to do most of the options

Eveeifyeve avatar Oct 11 '24 04:10 Eveeifyeve

don't feel obligated to add all the options, you can simply add options that are likely to be used by all users of this plugin

traxys avatar Oct 11 '24 11:10 traxys

error: build of '/nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv' on 'ssh-ng://[email protected]' failed: builder for '/nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv' failed with exit code 1;
       last 9 log lines:
       > ERROR: Error detected while processing /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:
       > E5113: Error while calling lua chunk: /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:9: module 'cord-nvim' not found:
       >    no field package.preload['cord-nvim']
       >  no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/share/lua/5.1/cord-nvim.lua'
       >    no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/share/lua/5.1/cord-nvim/init.lua'
       >       no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/lib/lua/5.1/cord-nvim.so'
       > stack traceback:
       >     [C]: in function 'require'
       >     /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:9: in main chunk
       For full logs, run 'nix log /nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv'.

khaneliman avatar Oct 11 '24 20:10 khaneliman

error: build of '/nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv' on 'ssh-ng://[email protected]' failed: builder for '/nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv' failed with exit code 1;
       last 9 log lines:
       > ERROR: Error detected while processing /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:
       > E5113: Error while calling lua chunk: /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:9: module 'cord-nvim' not found:
       >    no field package.preload['cord-nvim']
       >  no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/share/lua/5.1/cord-nvim.lua'
       >    no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/share/lua/5.1/cord-nvim/init.lua'
       >       no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/lib/lua/5.1/cord-nvim.so'
       > stack traceback:
       >     [C]: in function 'require'
       >     /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:9: in main chunk
       For full logs, run 'nix log /nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv'.

Yeah still can't figure out how to fix the issue.

Eveeifyeve avatar Oct 11 '24 20:10 Eveeifyeve

Ops.

Eveeifyeve avatar Oct 11 '24 20:10 Eveeifyeve

Sorry, I edited my suggestion, Didn't mean to remove the originalName

khaneliman avatar Oct 11 '24 20:10 khaneliman

Dropped the commit.

Eveeifyeve avatar Oct 11 '24 20:10 Eveeifyeve

don't feel obligated to add all the options, you can simply add options that are likely to be used by all users of this plugin

Well I am trying to add all of the options but it shouldn't be too hard to manage as options hasn't been changed in ages.

Eveeifyeve avatar Oct 11 '24 20:10 Eveeifyeve

I will work on more of the options tmr I need to sleep.

Eveeifyeve avatar Oct 11 '24 21:10 Eveeifyeve

I didn't have time today but I will look into add more options asap.

Eveeifyeve avatar Oct 12 '24 22:10 Eveeifyeve

don't feel obligated to add all the options, you can simply add options that are likely to be used by all users of this plugin

Well I am trying to add all of the options but it shouldn't be too hard to manage as options hasn't been changed in ages.

Just to clarify, the reason we don't need to declare all upstream options is that settings is a "freeform" option.

That means users can configure anything under plugins.*.settings even if we don't declare a corresponding option.

In fact, any options declared actually add additional restrictions due to their type checking. So when we do declare options we must ensure the type is permissive enough to allow users to configure anything upstream may allow.

MattSturgeon avatar Oct 12 '24 22:10 MattSturgeon

Hey @khaneliman Is it normal for docs not building manual using the docs & serve-docs command in shell?

Logs:

warning: ignoring untrusted substituter 'https://nix-community.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
error: builder for '/nix/store/hk274n3racxlcxzs635c09wz2qd2lxka-nuscht-search-pnpm-deps.drv' failed with exit code 1;
       last 10 log lines:
       >     at ClientRequest.emit (node:events:519:28)
       >     at emitErrorEvent (node:_http_client:108:11)
       >     at TLSSocket.socketErrorListener (node:_http_client:511:5)
       >     at TLSSocket.emit (node:events:531:35)
       >     at emitErrorNT (node:internal/streams/destroy:169:8)
       >     at emitErrorCloseNT (node:internal/streams/destroy:128:3)
       >     at processTicksAndRejections (node:internal/process/task_queues:82:21)
       >     at runNextTicks (node:internal/process/task_queues:64:3)
       >     at listOnTimeout (node:internal/timers:545:9)
       > Progress: resolved 946, reused 0, downloaded 944, added 944
       For full logs, run 'nix-store -l /nix/store/hk274n3racxlcxzs635c09wz2qd2lxka-nuscht-search-pnpm-deps.drv'.
error: 1 dependencies of derivation '/nix/store/rjam0130s3wsas7sdyyr7pjlcyvzm639-nuscht-search-0.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/1fwhi44fv1ksqbkc5j92jpnxmn8r80dh-nuscht-search.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vy73i7z7fgqvq10nnb7brwfnxiv82l7s-nixvim-docs.drv' failed to build

Cause I am building docs manually to see where I need to improve. I am also doing this to clarify for myself this comment

Eveeifyeve avatar Oct 18 '24 08:10 Eveeifyeve

Is it normal for docs not building manual using the docs & serve-docs command in shell?

If you're on darwin (OSX) then we disable the docs because mdbook has an upstream issue. Otherwise no, that could be a bug.

  • Are you on darwin?
  • Do you only see this issue on your branch, or is it on main too?

MattSturgeon avatar Oct 18 '24 09:10 MattSturgeon

Is it normal for docs not building manual using the docs & serve-docs command in shell?

If you're on darwin (OSX) then we disable the docs because mdbook has an upstream issue. Otherwise no, that could be a bug.

* Are you on darwin?

* Do you only see this issue on your branch, or is it on `main` too?

I am on x86_64-linux I just pulled the changes from main and rebased my branch so this is a bug.

Eveeifyeve avatar Oct 18 '24 10:10 Eveeifyeve

Is it normal for docs not building manual using the docs & serve-docs command in shell?

If you're on darwin (OSX) then we disable the docs because mdbook has an upstream issue. Otherwise no, that could be a bug.

* Are you on darwin?

* Do you only see this issue on your branch, or is it on `main` too?

but also what issue is on darwin cause I want to debug the issue as I have a darwin machine.

Eveeifyeve avatar Oct 18 '24 10:10 Eveeifyeve

You can see in docs/default.nix where we disable it using optionalAttrs (!pkgs.stdenv.isDarwin):

https://github.com/nix-community/nixvim/blob/3c7b6ae5d1524c691a1b65f7290facd0dc296e40/docs/default.nix#L68-L90

I'm not too familiar, but it's an upstream issue. If you do want to look into that, let's deal with it in another issue as I don't want it to distract from landing the changes here.

MattSturgeon avatar Oct 18 '24 12:10 MattSturgeon

Is it normal for docs not building manual using the docs & serve-docs command in shell?

If you're on darwin (OSX) then we disable the docs because mdbook has an upstream issue. Otherwise no, that could be a bug.

* Are you on darwin?

* Do you only see this issue on your branch, or is it on `main` too?

I am on x86_64-linux I just pulled the changes from main and rebased my branch so this is a bug.

Also would that be a bug?

Eveeifyeve avatar Oct 18 '24 13:10 Eveeifyeve

I'm able to serve-docs on main and this branch.

khaneliman avatar Oct 18 '24 13:10 khaneliman

Weird for some reason it fails.

Eveeifyeve avatar Oct 18 '24 13:10 Eveeifyeve

I'm able to serve-docs on main and this branch.

Both this branch and upstream are not working on x86_64-linux.

Eveeifyeve avatar Oct 19 '24 06:10 Eveeifyeve

I'm able to serve-docs on main and this branch.

I have made an issue on their end to see if they can fix it.

Eveeifyeve avatar Oct 19 '24 06:10 Eveeifyeve

I am going to work on getting the options finished then sqrash then it will be ready to review.

Eveeifyeve avatar Dec 07 '24 08:12 Eveeifyeve

I am about to start squashing my commits and provide settings that I only need.

Eveeifyeve avatar Jan 07 '25 17:01 Eveeifyeve

I might wait until v2 comes out before merging this as a lot of options change.

Eveeifyeve avatar Jan 07 '25 17:01 Eveeifyeve

I will start implementing v2 options.

Eveeifyeve avatar Jan 07 '25 17:01 Eveeifyeve

As this PR was stalling for the past few months, I took the initiative to go and finish it up.

As we tend to avoid explicitly declaring plugin options, I have chosen to only add settingsExample.

GaetanLepage avatar Apr 02 '25 06:04 GaetanLepage

@mergifyio queue

GaetanLepage avatar Apr 02 '25 12:04 GaetanLepage

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8ffda5afb163ff9604e34c0af552693dc76ed4e0

mergify[bot] avatar Apr 02 '25 12:04 mergify[bot]

This pull request, with head sha 8ffda5afb163ff9604e34c0af552693dc76ed4e0, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 8ffda5afb163ff9604e34c0af552693dc76ed4e0 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch plugins/cord-nvim, this means GitHub will fail to detect the merge.

mergify[bot] avatar Apr 02 '25 12:04 mergify[bot]