nixvim icon indicating copy to clipboard operation
nixvim copied to clipboard

Support neovim 0.7 features

Open pta2002 opened this issue 2 years ago • 1 comments

Neovim 0.7 has just come out, and there are a few features which would be a great fit for nixvim:

  • [ ] support for autocomands - now with a lua API, so it's way easier to support
  • [ ] support lua keybinds (use vim.keymap.set)
  • [ ] support highlight groups
  • [ ] support `filetype.lua

I plan to begin working on these in the following weeks - none of them should be particularly difficult

pta2002 avatar Apr 15 '22 15:04 pta2002

Something extra which would probably be a good fit here - compatibility checks. Would be really helpful if we could short-circuit while still in Nix, and say "this feature requires neovim >= 0.7", or use a backwards-compatible, but less efficient, method.

pta2002 avatar May 04 '22 10:05 pta2002

Looks like we're already to v0.8.1, but that's not in NixOS unstable yet, let alone stable 😅

rummik avatar Nov 20 '22 21:11 rummik

v0.8.2 has been merged to nixos-unstable :)

GaetanLepage avatar Jan 04 '23 22:01 GaetanLepage

Yeah, I'll need to create a github project for all these features with individual issues, should be the better way to go about it honestly

pta2002 avatar Jan 04 '23 22:01 pta2002

@pta2002 what do you mean by "support filetype.lua" ? From this post, it seems that the behavior can be changed by simply changing global variables. Moreover, it seems that the lua filetype detection has been enabled by default since https://github.com/neovim/neovim/pull/19216.

I guess there is nothing to do for us here then. As this was the last thing on this list, we might close this issue. Have I missed anything ?

GaetanLepage avatar Apr 16 '23 21:04 GaetanLepage

I think I meant support for generating filetype.lua files

pta2002 avatar Apr 16 '23 21:04 pta2002

I think I meant support for generating filetype.lua files

Oh ok ! I have no idea how this works though...

GaetanLepage avatar Apr 16 '23 21:04 GaetanLepage

I just remembered that @traxys already wrapped the vim.fileype.add function: https://github.com/pta2002/nixvim/pull/277 Do you think of any missing feature @pta2002 ?

GaetanLepage avatar Apr 16 '23 21:04 GaetanLepage

Didn't notice that PR! Good enough for me :) I'll close this then!

pta2002 avatar Apr 17 '23 08:04 pta2002