nixos-vscode-server icon indicating copy to clipboard operation
nixos-vscode-server copied to clipboard

Add option to enable the service for all users

Open Ten0 opened this issue 1 year ago • 8 comments
trafficstars

Resolves #69 Resolves #65

What it does:

  • When the services.vscode-server.enableForUsers.enable = true is specified and using nixos-vscode-server as a NixOS module, uses tmpfiles to setup the appropriate symlinks to enable the service for all regular users
  • Adds relevant instructions to the README
  • Also adds instructions to the README to add instructions about how to use nixos-vscode-server as a home-manager module in combination with flakes

Ten0 avatar Jul 03 '24 15:07 Ten0

Just as a sanity check is there a reason the scope of this is only to enable the service for all users? is enabling the ability to specify the specific users to enable the service on a big change? thanks for making this PR

fsnkty avatar Oct 16 '24 06:10 fsnkty

No that wouldn't be a big change and it would also make sense. I have pretty much lost hope that this is ever getting merged though so I'm not investing more time in this, as there is no active maintainer on this project (https://github.com/nix-community/nixos-vscode-server/issues/67#issuecomment-1991011917, but then I got ghosted, which honestly is understandable as the xz story happened at about the same time so they probably got suddenly unadventurous 😅).

I would be willing to merge a PR to this branch to my fork though 😊

Ten0 avatar Oct 16 '24 09:10 Ten0

No that wouldn't be a big change and it would also make sense. I have pretty much lost hope that this is ever getting merged though so I'm not investing more time in this, as there is no active maintainer on this project (#67 (comment), but then I got ghosted, which honestly is understandable as the xz story happened at about the same time so they probably got suddenly unadventurous 😅).

understandable, maybe its time to look into finding the right person to ask about managing nix-community here given they seem both unable to work on the repo and unwilling (?) to allow someone else to.

unfortunate, guess I'll get to solving this elsewhere

fsnkty avatar Oct 16 '24 09:10 fsnkty

@Ten0 Due to various reasons I don't want to continue working on this project. I asked before (in matrix), without success, but now someone looked into it and turned out I wasn't admin of my own project (explained why I could not find the settings page no matter what I tried). I just invited you as maintainer.

msteen avatar Oct 17 '24 08:10 msteen

Thanks! 😊 I'll do my best 😊

Ten0 avatar Oct 17 '24 09:10 Ten0

Hey, thanks so much for taking over! so is this getting merged?

Edit: I just saw that this was a very recent development, so take your time haha

moritztim avatar Oct 18 '24 02:10 moritztim

@fsnkty does the new proposed interface look good to you?

Ten0 avatar Oct 19 '24 18:10 Ten0

Anything blocking this from getting merged?

RyzeNGrind avatar Apr 18 '25 06:04 RyzeNGrind

Can this be merged? @fsnkty @Ten0

tfc avatar Oct 08 '25 08:10 tfc