nixos-generators icon indicating copy to clipboard operation
nixos-generators copied to clipboard

Upstream virtualization fix sprint

Open blaggacao opened this issue 4 years ago • 3 comments

I've noticed that some upstream modules under nixos/modules/virtualisation are actually in pretty bad shape.

To gather and coordinate a fixing sprint, I've just setup https://matrix.to/#/!LhhFDmfZUkcXRvvvxM:matrix.org?via=matrix.org&via=nordgedanken.dev

Please join if you're interested.

I open this issue here, since I assume several users of nixos-generators have vested interests in the possible outcomes of this.

@Lassulus It would be really amazing if we could somehow team up to push this agenda. (together with other stranded devos users)

blaggacao avatar Jun 14 '21 03:06 blaggacao

sounds good, I'm currently fighting against my matrix setup, so as soon as I have that figured out I can join the channel :D

Lassulus avatar Jun 14 '21 07:06 Lassulus

This was a first item:

https://github.com/NixOS/nixpkgs/pull/131760

@Lassulus I think your mkOverride 60 suggestion sets a very good precedent on how to make those class of modules aggregable to existing host configs without generating any kind of conflict (neither with normal host config, nor with conscientiously targeted overrides for any specific image).

blaggacao avatar Jul 28 '21 13:07 blaggacao

here is a recent addition of mine: https://github.com/NixOS/nixpkgs/pull/131312 maybe we should think about a common interface we want to export in every module. currently some modules don't even have any options and the ones which have some are very different.

Lassulus avatar Jul 28 '21 13:07 Lassulus