nixd icon indicating copy to clipboard operation
nixd copied to clipboard

nixd/tools/nixd-attrset-eval: support completion for "builtins"

Open inclyc opened this issue 1 year ago • 6 comments

Basic support for option completion on the worker process. This is the premise for doing this in LSP.

Link: #507

inclyc avatar Nov 19 '24 08:11 inclyc

@inclyc did you request my review for something specific or more for a general review?

Mic92 avatar Nov 19 '24 09:11 Mic92

@inclyc did you request my review for something specific or more for a general review?

A specific review for C++ nix IPC:

This pull request introduces the ability to query builtins information. Do you think the methodology is correct, or does it need refinement?

Very appreciated if you can take a look :)

inclyc avatar Nov 19 '24 09:11 inclyc

It looks reasonable to me and similar to what the nix repl does for completing. However I would prefer if @roberth would have a look as well.

Mic92 avatar Nov 19 '24 15:11 Mic92

Hey! Checking in here.

What all needs to be done to get this working?

More than happy to get the ball rolling assuming I can be of any help.

PriceHiller avatar Feb 16 '25 17:02 PriceHiller

Hey! Checking in here.

What all needs to be done to get this working?

More than happy to get the ball rolling assuming I can be of any help.

Actually, this PR is related to the technical approach of #625. I’m considering proposing a technical solution that would work well for both #625 and this PR, but I haven’t had the time to write the code recently. If you’re interested, you could explore the connection between the technical approaches of these two PRs and help move this work forward.

inclyc avatar Feb 17 '25 03:02 inclyc

Rebased. Resolving merge conflicts.

inclyc avatar Apr 26 '25 15:04 inclyc

Closed, prefer https://github.com/nix-community/nixd/pull/677

inclyc avatar May 04 '25 14:05 inclyc