napalm icon indicating copy to clipboard operation
napalm copied to clipboard

Published 20 hours ago • verified publisher icon nix-community

Fixed lock-patcher not working for older node.js versions

Open Mazurel opened this issue 3 years ago • 4 comments

While using the latest version of Napalm, I have discovered that when node.js version is below 14.13.0, then it will fail running lock-patcher.mjs due to module or fsPromise support. This PR makes it so that when node.js version is below 14.13.0 it will use the latest node.js from the nixpkgs, otherwise it will use the one specified by the user.

Mazurel avatar Oct 14 '21 18:10 Mazurel

Sorry, I forgot about this. Is this still needed?

jtojnar avatar Apr 05 '22 22:04 jtojnar

I guess it might be useful for packaging older applications. It just caps minimum node.js version for running lock-patcher.mjs.

Btw sorry for responding so late, I have missed the notification somehow.

Mazurel avatar May 29 '22 09:05 Mazurel

Node 14 is the oldest supported Node version so I would say people really should update if they want to use Napalm.

jtojnar avatar May 29 '22 11:05 jtojnar

Yeah, I agree, although I made this change because I was packaging Manyverse, which uses node.js version 12, so apparently this may be an issue for someone.

Mazurel avatar May 29 '22 13:05 Mazurel