home-manager icon indicating copy to clipboard operation
home-manager copied to clipboard

bug: programs.mpv.config.glsl-shaders should join entries by ';'

Open arvigeus opened this issue 2 years ago • 0 comments

Are you following the right branch?

  • [X] My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • [X] I have searched the existing issues

Issue description

Example:

programs.mpv.config = {
  glsl-shaders = [
    "~~/shaders/FSR.glsl"
    "~~/shaders/CAS-scaled.glsl"
  ]
};

Should produce

glsl-shaders=%122%~~/shaders/FSR.glsl;~~/shaders/CAS-scaled.glsl

(a ; separated list - source)

Instead it produces

glsl-shaders=%122%~~/shaders/FSR.glsl
glsl-shaders=%129%~~/shaders/CAS-scaled.glsl

Where the second definition overrides the first.

Technically, it can be workarround-ed with glsl-shaders = builtins.concatStringsSep ";" [ ... ].

Maintainer CC

@tadeokondrak @thiagokokada @chuangzhu

System information

Not on my NixOS machine RN; it doesn't matter here.

arvigeus avatar Apr 11 '24 08:04 arvigeus