home-manager icon indicating copy to clipboard operation
home-manager copied to clipboard

activitywatch: add module

Open foo-dogsquared opened this issue 9 months ago • 4 comments

Description

Adding ActivityWatch service which is fully intended to be local for the user so adding this to home-manager is a nice fit.

This service is fully deployed and managed by systemd instead of the traditional way of using it by running aw-qt which opens up a system tray.

Checklist

  • [x] Change is backwards compatible.

  • [x] Code formatted with ./format.

  • [x] Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • [x] Test cases updated/added. See example.

  • [x] Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • [x] Added myself as module maintainer. See example.

Maintainer CC

foo-dogsquared avatar Sep 09 '23 06:09 foo-dogsquared

Updated the module, resolved the merge conflicts, and rebased it on top of 6a8444467c83c961e2f5ff64fb4f422e303c98d3.

foo-dogsquared avatar Nov 10 '23 07:11 foo-dogsquared

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.
If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

stale[bot] avatar Feb 09 '24 06:02 stale[bot]

Rebased the PR to current master revision and also updated the tests and the news item.

foo-dogsquared avatar Feb 11 '24 11:02 foo-dogsquared

Is this going to be merged anytime soon?

voobscout avatar Feb 13 '24 06:02 voobscout

Seems I accidentally made review comments instead of real comments so they never showed up 🙁

By the way, there is no need to add a news item, we can add it when doing the merge. To help avoid these merge conflicts.

rycee avatar Mar 09 '24 12:03 rycee

All right, I've pushed with the suggested changes and added a new test.

By the way, there is no need to add a news item, we can add it when doing the merge. To help avoid these merge conflicts.

Got it.

foo-dogsquared avatar Mar 10 '24 03:03 foo-dogsquared

Thanks! I made a few minor final fixes, mainly to reduce the download size for the tests. Merged to master now 🙂

rycee avatar Mar 15 '24 09:03 rycee