programs.sway: always wrap the provided package

[teto]

when swapping the sway package with another (e.g., "swayfx") we lose HM's wrapping like session variables, command line arguments etc for no reason. It's inconsistent with how the neovim module behaves too.

If someone wants to bypass the HM wrapping, it's still possible to wrap the package with a function .

Description

Checklist

• [ ] Change is backwards compatible.

• [x] Code formatted with ./format.

• [x] Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• [x] Test cases updated/added. See example.

• [ ] Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • [ ] Added myself as module maintainer. See example.

[teto]

so I lost a few minutes before discovering the tests ran with a mock/stub "sway". It's pretty smart but the module needs to override sway which broke with the stub. It was simpler to remove the stub so that's what I have done. My changes to the tests fixed make TEST=sway-bar-focused-colors test but before I proceed, I would like confirmation that my changes are OK. I am a bit confused by the status_command @i3status@/bin/i3status that dont seem to get replaced/normalized. Is that due to the change in stubs/is it expected ? cc @rycee @sigprof

[teto]

this requires some changes tin nixpkgs to work, so I will try to merge https://github.com/NixOS/nixpkgs/pull/237044 first

[stale[bot]]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[stale[bot]]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[rycee]

The sway-stubs.nix file contains i3status = { };, which I think would explain the @i3status@.

Does this change mean that the CI will download Sway and its dependencies?