home-manager icon indicating copy to clipboard operation
home-manager copied to clipboard

Mako systemd

Open Rosuavio opened this issue 2 years ago • 3 comments

Description

Checklist

  • [ ] Change is backwards compatible.

  • [ ] Code formatted with ./format.

  • [ ] Code tested through nix-shell --pure tests -A run.all.

  • [ ] Test cases updated/added. See example.

  • [ ] Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • [ ] Added myself as module maintainer. See example.

    • [ ] Added myself and the module files to .github/CODEOWNERS.

Rosuavio avatar Sep 26 '22 05:09 Rosuavio

Maybe I should do something like... https://github.com/nix-community/home-manager/blob/9e7394523eb4f298528d457e316fc752bdf07151/modules/programs/waybar.nix#L198-L212

Rosuavio avatar Sep 26 '22 05:09 Rosuavio

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.
If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

stale[bot] avatar Dec 25 '22 15:12 stale[bot]

Thanks working on this! I recently ran into the situation resulting in exec failed: No such file or directory, because mako has been spawned by systemd --user which doesn't have the proper sh on PATH, but mako expects this being POSIX compliant. I changed to starting mako with sway and this works fine, but I think a dedicated user service is the right choice to provide all flexibility needed.

By the way, this popped up with a very simple example of using actions in mako:

[summary="Screenshot copied to clipboard"]
on-button-right=exec ${pkgs.wl-screenshot}/bin/wl-screenshot upload

v4rakh avatar Feb 17 '24 15:02 v4rakh

Closed because it seems we don't need a systemd service for mako, and she sh thing seems solved in nixpkgs https://github.com/nix-community/home-manager/issues/3893#issuecomment-1969618171 now.

Rosuavio avatar Feb 28 '24 19:02 Rosuavio