home-manager icon indicating copy to clipboard operation
home-manager copied to clipboard

batsignal: add module

Open loicreynier opened this issue 2 years ago • 1 comments

Description

Adds batsignal module.

Checklist

  • [x] Change is backwards compatible.

  • [x] Code formatted with ./format.

  • [x] Code tested through nix-shell --pure tests -A run.all.

  • [x] Test cases updated/added. See example.

  • [x] Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • [x] Added myself as module maintainer. See example.

    • [x] Added myself and the module files to .github/CODEOWNERS.

loicreynier avatar Sep 20 '22 11:09 loicreynier

I wanted to add the dangerLevelCommand option to the test, but since it generates an entry in the store for the generated shell script I don't know how to deal with it:

[Service]
ExecStart=@batsignal@/bin/batsignal -w 15 -c 5 -d 2 -f 5 -D /nix/store/fv4mq8q355016vraa178bndbqa75w4rx-batsignal-dangercmd -n 'Internal' -m 120 -a 'Batsignal daemon' -I battery

loicreynier avatar Sep 20 '22 11:09 loicreynier

I fixed the test (typo in expected service config), simplified the package option with mkPackageOption and rebased into master.

loicreynier avatar Nov 27 '22 14:11 loicreynier

I added the dangerLevelCommand to the test using normalizeStorePaths. I also added all the other options to the test which is now complete.

loicreynier avatar Dec 01 '22 11:12 loicreynier

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.
If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

stale[bot] avatar Mar 02 '23 03:03 stale[bot]

Thanks for the review @sumnerevans, I changed what your requested.

loicreynier avatar Mar 02 '23 16:03 loicreynier

Closing in favor of #3791.

loicreynier avatar Mar 20 '23 11:03 loicreynier