home-manager icon indicating copy to clipboard operation
home-manager copied to clipboard

leftwm: add module

Open sevenautumns opened this issue 3 years ago • 7 comments

Description

Adds the LeftWM window manager

Checklist

  • [x] Change is backwards compatible.

  • [x] Code formatted with ./format.

  • [x] Code tested through nix-shell --pure tests -A run.all. On my system (Arch btw) all test pass except for nnn. But the test fails with and without my commit.

  • [x] Test cases updated/added. See example.

  • [x] Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • [x] Added myself as module maintainer. See example.

    • [x] Added myself and the module files to .github/CODEOWNERS.

sevenautumns avatar Feb 19 '22 23:02 sevenautumns

@berbiche I tried to apply all of your suggestions.
Furthermore I added types.attrsOf (types.either types.package themeSubmodule) to themes as well. This way individual themes can be included as packages too.

I extended the leftwm-theme-test for the new possibilities.

Should I squash my commits or will the commits be squashed on merge?

sevenautumns avatar Feb 20 '22 13:02 sevenautumns

all test pass except for nnn

Thanks to b3af91d, all tests pass now

sevenautumns avatar Feb 22 '22 09:02 sevenautumns

Hi, I'll finish my review next week when I have time.

berbiche avatar Feb 23 '22 23:02 berbiche

@berbiche
I simplified the theme config in a way that only packages and subattribute packages are expected. This way we do not lose any documentation and the documentation itself is lighter.

sevenautumns avatar Feb 28 '22 17:02 sevenautumns

@berbiche Can I request another review from you?

sevenautumns avatar Apr 20 '22 11:04 sevenautumns

@berbiche Can I request another review from you?

Sure, I'll review this as soon as possible.

berbiche avatar Apr 20 '22 18:04 berbiche

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.
If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

stale[bot] avatar Aug 31 '22 01:08 stale[bot]

This has gotten a little stale, and LeftWM has adopted a new configuration format and deprecated TOML as a configuration format going forward.

I have a similar module and RON config file generator that I've been using inside my own personal configuration for a while, and was wondering what the current status of this PR was before I filed a PR with my own take on implementing a LeftWM module.

water-sucks avatar Dec 27 '23 06:12 water-sucks

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.
If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

stale[bot] avatar Mar 31 '24 06:03 stale[bot]