fenix icon indicating copy to clipboard operation
fenix copied to clipboard

Add `fromToolchainName` to targets

Open soywod opened this issue 1 year ago • 7 comments

This would allow combining components from a specific version in a cross compilation context:

[toolchain]
channel = "1.77.0"
profile = "default"
components = [ "rust-src", "rust-analyzer" ]
let
  name = (pkgs.lib.importTOML ./rust-toolchain.toml).toolchain.channel;
  fenixPackage = fenix.packages.${buildPlatform};
  toolchain = fenixPackage.fromToolchainName { inherit name sha256; };
  targetToolchain = fenixPackage.targets.${targetPlatform}.fromToolchainName { inherit name sha256; };
in
fenixPackage.combine [
  toolchain.rustc
  toolchain.cargo
  targetToolchain.rust-std
];

soywod avatar Apr 14 '24 08:04 soywod

Any news about it?

soywod avatar Nov 22 '24 06:11 soywod

@soywod You should probably revert 86c0fc2, and rebase against fenix/main, otherwise we end up with merge commits in a PR :)

shymega avatar Nov 23 '24 15:11 shymega

I'm in favour of this PR, fwiw.

shymega avatar Nov 23 '24 15:11 shymega

Thank you @shymega :wink: I just pushed the rebase.

soywod avatar Nov 23 '24 23:11 soywod

Is this project dead? Looks like PRs are accumulating and nobody takes care of them :disappointed:

soywod avatar Jan 10 '25 13:01 soywod

Is this project dead? Looks like PRs are accumulating and nobody takes care of them 😞

Its not dead anymore now :3

nyabinary avatar Jun 01 '25 02:06 nyabinary

Are there any blockers for merging this?

charludo avatar Jun 17 '25 08:06 charludo

I don't think so.

soywod avatar Jul 09 '25 13:07 soywod

FWIW, we're using @soywod's patch without issue in our project, so consider this an approving review from someone without merge rights 😄

charludo avatar Jul 09 '25 13:07 charludo

Is this project dead? Looks like PRs are accumulating and nobody takes care of them 😞

Its not dead anymore now :3

@nyabinary in that case, would you mind reviewing/merging this? 😄

charludo avatar Jul 22 '25 13:07 charludo