emacs-overlay icon indicating copy to clipboard operation
emacs-overlay copied to clipboard

Add `feature/tree-sitter` derivation to emacs overlay

Open yilinwei opened this issue 2 years ago • 4 comments

Fixes #226 for Linux.

I don't have a Mac to get this to work and test it for Darwin. I think it will be a matter of switching .so to the required extension.

Note, the dynamic libraries need to be set during the buildPhase otherwise the build fails. As more languages get added into emacs core, more tree-sitter-grammars need to be added.

yilinwei avatar Oct 12 '22 18:10 yilinwei

This is without native compilation, right? Would be possible to have also a version with native compilation?

aciceri avatar Oct 14 '22 10:10 aciceri

This is without native compilation, right?

This is with native compilation like all emacs variants in this overlay and nixpkgs.

jian-lin avatar Oct 14 '22 11:10 jian-lin

This is with native compilation like all emacs variants in this overlay and nixpkgs.

Oh, it's been a while since I last used this overlay... By the way maybe we want to make Hydra build this emacsen too?

aciceri avatar Oct 14 '22 12:10 aciceri

With 29.0 branch-off expected in less than 2 months, I think we can simply wait and make tree-sitter default for unstable builds, as it appears will be the case upstream.

bhankas avatar Oct 15 '22 13:10 bhankas

/cc @leungbk @jian-lin

Updated PR based on comments.

yilinwei avatar Oct 17 '22 09:10 yilinwei

Thanks!

leungbk avatar Oct 17 '22 09:10 leungbk