bundix icon indicating copy to clipboard operation
bundix copied to clipboard

Add support for platform windows

Open cjlarose opened this issue 1 year ago • 4 comments

Fixes https://github.com/nix-community/bundix/issues/57

Several gems declare platform support for windows, including several dependencies of a newly-generated rails app

  • debug (1.9.1)
  • io-console (0.7.2)
  • irb (1.11.1)
  • psych (5.1.2)
  • rdoc (6.6.2)
  • reline (0.4.2)
  • stringio (3.1.0)

cjlarose avatar Feb 08 '24 05:02 cjlarose

@inscapist would we be able to get this merged into your fork?

jonknapp avatar Apr 06 '24 22:04 jonknapp

For context it looks like “windows” was added as an alias for existing windows platforms in bundler: https://github.com/rubygems/rubygems/pull/5650

I encountered the issue as new Rails app Gemfiles use this alias instead of the mingX platforms it did before.

jonknapp avatar Apr 09 '24 00:04 jonknapp

@jonknapp thanks for providing the context, a PR has been merged into my fork!

inscapist avatar Apr 09 '24 16:04 inscapist

@manveru Any chance you could take a look at this? If a gem like irb gets updated now, this results in an unclear error /nix/store/np0gx2m7xkxrvx3ack88bv1zlpkcrgw9-bundix-2.5.2/lib/ruby/gems/3.1.0/gems/bundix-2.5.0/lib/bundix/nixer.rb:100:in serialize': Cannot convert to nix: nil`

I tried these changes in a repository where I ran into this issue and they generated the expected gemset.

robbevp avatar Aug 02 '24 17:08 robbevp