nivekuil
put suggested keybindings into a minor-mode keymap?
One of the magical things about packages is they let me keep my ~/.emacs.d/init.el under a few dozen megabytes; in service of keeping things small, I like to adhere to default keybindings wherever possible and not have custom code for setting them up.
Would you consider putting the keybindings in the README for corral into a minor mode that I can just activate and inspect to see how it's used?
That sounds like a neat feature, and easy enough to add. My elisp is pretty rusty and I'm not sure what the best practices are for a minor mode purely for keybinds - could you point me to any examples? Of course if you want to add it yourself I am more than happy to accept the PR :)
Sent from my T-Mobile 4G LTE Device -------- Original message --------From: Glyph [email protected] Date: 8/25/18 3:54 PM (GMT-08:00) To: nivekuil/corral [email protected] Cc: Subscribed [email protected] Subject: [nivekuil/corral] put suggested keybindings into a minor-mode keymap? (#11) One of the magical things about packages is they let me keep my ~/.emacs.d/init.el under a few dozen megabytes; in service of keeping things small, I like to adhere to default keybindings wherever possible and not have custom code for setting them up. Would you consider putting the keybindings in the README for corral into a minor mode that I can just activate and inspect to see how it's used?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/nivekuil/corral","title":"nivekuil/corral","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/nivekuil/corral"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"put suggested keybindings into a minor-mode keymap? (#11)"}],"action":{"name":"View Issue","url":"https://github.com/nivekuil/corral/issues/11"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/nivekuil/corral/issues/11", "url": "https://github.com/nivekuil/corral/issues/11", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "put suggested keybindings into a minor-mode keymap? (#11)", "sections": [ { "text": "", "activityTitle": "Glyph", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@glyph", "facts": [ { "name": "Repository: ", "value": "nivekuil/corral" }, { "name": "Issue #: ", "value": 11 } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "IssueComment",\n"repositoryFullName": "nivekuil/corral",\n"issueId": 11,\n"IssueComment": "{{IssueComment.value}}"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "IssueClose",\n"repositoryFullName": "nivekuil/corral",\n"issueId": 11\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/nivekuil/corral/issues/11" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "MuteNotification",\n"threadId": 372392551\n}" } ], "themeColor": "26292E" } ]
