Justin Louie

Results 60 comments of Justin Louie

Would love to get this one loaded as hotwire becomes more readily used.

@lanzhiheng manually pulled all these changes in. One area that's still broken seems to be form validation errors on `/edit` pages. For some reason they do redirects back to the...

> Adding transition error to object.errors is possible but adding guards error from some other transition will be tricky. For clarification, do you mean that adding guard errors from the...

> Moving from `completed` to `cancelled` , you want money deposited error but money deposited error is added in guard for transition from `verifying` to `cancelled` therefore I thought you...

@anilmaurya thanks that makes a lot of sense. How would you like me to handle this feature request? Split the base/2nd request cases? Close as won't fix? I still think...

Hi guys, any thoughts on how to get the test/test-migration to pass? Really looking forward to this PR merged in!

@donrestarone thanks for the PR! I don't think we should add the upgrade migration files for activestorage (5.2 => 6.1). I'm not a maintainer, so I can only guess at...

@donrestarone actually based on your comment I realized the `00_create_active_storage_tables.active_storage.rb` is not even loaded/"generated", only the [`01_...` file is](https://github.com/comfy/comfortable-mexican-sofa/blob/master/lib/generators/comfy/cms/cms_generator.rb#L22). So that means the 00 file is only for internal CMS...

Late to the party, but out of curiosity, why not set it in general as in `I18n.locale = params[:lang1]`? I've personally had difficulties with full request `around_actions` for setting time...