Nicolas Brassard

Results 407 comments of Nicolas Brassard

Events don't have a execute fonction do they ?

> Yes, in my understanding of XSRF it makes sense to protect the login form. Yes it does!!! > Creating a Symphony object alone (without any pages being created) wouldn't...

> It does not. It simply does not make sense to protect the login page, as that would imply you know the login details. Which renders the entire attack superflous......

> this only works if the session is destroyed on an unsuccessful login attempt. it should do that IMO. > Anyway, this scenario has nothing to do with XSRF. I...

> I think this is because of the time in the datasource output. Is there any way I can search without taking the time into consideration? It sure does! Do...

> So if we want a "better Date Field", We already [have one](https://github.com/DeuxHuitHuit/datetime) ;) And we [do set the value to force the time to be 0](https://github.com/DeuxHuitHuit/datetime/blob/master/fields/field.datetime.php#L586) I agree that...

> Honestly, I don't see that this has been dicussed in #2763. But we may discuss it, of course. We did not discussed it sorry, but I've mentioned it https://github.com/symphonycms/symphony-2/issues/2763#issuecomment-338829512...

Github suggested it and I told myself, what the heck, let's do it. Please do not see this as an "order" just like a @ mention.

And I do like when you review my shit 👍