nitric icon indicating copy to clipboard operation
nitric copied to clipboard

Add cloud event worker type

Open tjholm opened this issue 3 years ago • 3 comments

Adds a worker type that responds to cloud events.

tjholm avatar May 02 '22 00:05 tjholm

Codecov Report

Merging #274 (d780ddd) into develop (5ef4ffd) will decrease coverage by 2.19%. The diff coverage is 0.00%.

:exclamation: Current head d780ddd differs from pull request most recent head 95aad02. Consider uploading reports for the commit 95aad02 to get more accurate results

@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
- Coverage    61.63%   59.43%   -2.20%     
===========================================
  Files           43       44       +1     
  Lines         4371     4383      +12     
===========================================
- Hits          2694     2605      -89     
- Misses        1501     1603     +102     
+ Partials       176      175       -1     
Flag Coverage Δ
unittests 59.43% <0.00%> (-2.20%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/adapters/grpc/faas_grpc.go 0.00% <0.00%> (ø)
pkg/worker/cloud_event_worker.go 0.00% <0.00%> (ø)
pkg/worker/grpc_worker.go 50.00% <0.00%> (-11.23%) :arrow_down:
pkg/worker/http_worker.go 0.00% <0.00%> (ø)
pkg/worker/worker.go 66.66% <0.00%> (-33.34%) :arrow_down:
pkg/plugins/storage/storage/storage.go 71.42% <0.00%> (-6.98%) :arrow_down:
pkg/plugins/storage/azblob/azblob.go 74.85% <0.00%> (-3.51%) :arrow_down:
pkg/plugins/storage/s3/s3.go 54.05% <0.00%> (-0.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ef4ffd...95aad02. Read the comment docs.

codecov-commenter avatar May 02 '22 00:05 codecov-commenter

TODO: Need to discuss format for sources for standard nitric event registration for infrastructure provisioning (or decide if we separate out the binding definition.

A good example of this would be replacing our current topic subscription infrastructure with a cloud event binding. Where we define the source of the event to be the nitric topic:

example: nitric:topic:my-topic

or for binding a bucket event: nitric:bucket:my-bucket/my/file/path?event=write

to bind write events for a given file.

tjholm avatar May 02 '22 00:05 tjholm

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

sonarqubecloud[bot] avatar May 17 '22 00:05 sonarqubecloud[bot]

closing as stale

tjholm avatar Aug 29 '22 23:08 tjholm