Nitish Kumar
Nitish Kumar
I'd suggest learning about these things one at a time. For eg. What is the use of import command, why do we use the prune flag, and what is the...
This PR is in my list to review - I'll review this today.
> should I create a separate PR for the refactor? Not necessary, please do it in the same PR. Otherwise we'll have to wait for another PR to get merged...
> @nitishfy , should I refactor the NewImportCommand() func, in `backup.go`? And create multiple functions and then try to call it inside the `backup_test.go`? Yes, that's what I meant. Refactor...
> Got it, I'll try to make the changes most probably before tomorrow's call. Also, just wanted to ask, that after I pulled [some](https://github.com/argoproj/argo-cd/pull/22780/commits/61698be715879a3575c0b931e446f328be7b6318) changes, 5 checks are failing. I...
Can you fix the failing tests?
> > Did you try testing this on your fork? > > I did test that it produces the desirable version numbers to run the report against. What I did...
Also, I think I'll have to restructure the entire tests for `plugin_test.go` once the change is accepted.
@leoluz I'm personally in the opinion of searching for a plugin, starting with the longest prefix. Why would you want to follow another approach?
@leoluz @blakepettersson I'd need your feedback on this PR. Having said that, there are a few things I'd like to mention: 1. We need to decide if we would like...