js-vault
js-vault copied to clipboard
nitish24p
added discussion threads
I don't know why the mixed content test is failing because I didn't touch that file.
Also, I created a site for jsvault.com using my account, if you want you can change it just by changing the value of this variable https://github.com/nitish24p/js-vault/pull/15/files#diff-3ca9dc81f3a5e4ebb64a4c34f51e5340R8 . You can also move it to environment variable if you want but I don't think that it would be necessary.
Disqus loads wayyy to much on the page. Hampered performance like crazy. Wondering whether we should just use their api's if they provide any any build the rest on our own
@nitish24p I think it's happening because there are many requests being sent for fetching the threads and responses for the content, and that would have to be made anyways if we were to build custom components.
And Building a custom thread would get a bit complicated because we would have to integrate so many APIs and handle many edge cases, like, editing a comment, upvoting/downvoting a comment, replying to a comment and thereby opening a new thread, responses, etc.
@nitish24p I was scrolling through this https://beebom.com/get-digital-wellbeing-android-pie-no-root/ article when I saw a button in their comments section to load the comments and when I clicked on that button I saw that they were also using disqus for comments then I thought we could also use a similar method to improve the performance to load the comments, and hence I have also created a button that loads the comments when the user clicks on it.
I don't know why but the netlify preview was generated again and when I ran the audit once again on the new preview I got a perfect score on the preview this time.
