Nitish Phanse comments

Results 85 comments of


                                            Nitish Phanse

[Opinionated] Add alt attribute & remove container

can you run npm run eslint to see the lint errors and fix those

Config that decides whether to use shared or single worker: (This should be passed as props)

The point of this is whether it makes sense to spawn 4 workers for just a single image

Limit Workers to max. avail. CPUs

Each IMageWorker component will now spawn 4 worker threads. As we've removed the `worker.terminate` call, will those threads still be active when a componentWillUnMount gets called?

Limit Workers to max. avail. CPUs

can you run `npm run eslint` to see the lint errors and fix those

Write test cases using jest (snapshot testing)

😍

Is spawning a new worker for every image a good idea?

Yes this had come up into my head. Browsers offer support for using shared workers instances, so can try that or can terminate the worker once the inage has been...

Is spawning a new worker for every image a good idea?

@manjula91 thoughts..

Promisify a function

Yea works also add the route in routes.js

Add a contributors section with Twitter / Github Ids

sure

Implement the pipe function

Sure