redocx
redocx copied to clipboard
nitin42
`createBuffer` method
Hi there!
[This is an incomplete PR to start a conversation]
Love redocx. I'm trying to make an http server that can serve up small word docs without hitting the filesystem. I figured I'd add a method to convert to a buffer but I'm running into some trouble understanding officegen. It seems like the finalize event that we pass to generate gets called before the stream gets its first data event. Does that make sense?
Seems great to me! Can you upload a gif or something to show its behaviour? Then I'm happy to merge this!
So its not quite working yet, that’s the problem. I’m having trouble understanding why. It seems like the finalize method is called before… its finalized
Zeke
On Sep 22, 2017, 2:51 AM -0500, Nitin Tulswani [email protected], wrote:
Seems great to me! Can you upload a gif or something to show its behaviour? Then I'm happy to merge this! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
No this slipped off my stack, but I’m looking to get back to it next week
On Sep 30, 2017, 6:57 AM -0500, Nitin Tulswani [email protected], wrote:
Any progress? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
See #19. I can move the logic out of the render function, but it felt right to leave it there. The implementation is complete, with example.
