sensey icon indicating copy to clipboard operation
sensey copied to clipboard

Published 20 hours ago • verified publisher icon nisrulz

[Question] Enhancement of Javadocs

Open programmerr47 opened this issue 8 years ago • 2 comments

Hi. Recently I saw your update and you added javadocs, and I think for library project it's awesome. But may be it should be written more info than simple, for example, "Creates new Flip Detector", because when you write new FlipDetection(something) you already now, that you creating new Detector. I think it would be great if javadocs contained more specific info about, why we need, for example, such detector and e.t.c. What do you think about this idea?

programmerr47 avatar Jun 29 '16 05:06 programmerr47

@programmerr47 Yes, I added the basic javadocs using a plugin which populates the javadoc comments . I will update it when I do get the time. Meanwhile all PR are welcome :)

nisrulz avatar Jun 29 '16 07:06 nisrulz

@nisrulz Sounds great. By the way I've created a pull request with fixing bug of leaking "default" detectors.

The special test was introduced in pull request. In short we twice calling for example "startProximityDetection" and then two times "stopProximityDetection". Then we will still have one detector registered in sensorManager. I fixed that.

programmerr47 avatar Jun 29 '16 07:06 programmerr47