flutter-examples icon indicating copy to clipboard operation
flutter-examples copied to clipboard

[Fixes #97] Added a News & Memes App

Open Sriraj-dev opened this issue 3 years ago • 8 comments

What does this implement/fix? Explain your changes

Adds a new app to display News and Memes

Does this close any currently open issues?

  • [x] Yes, Fixes #97
  • [ ] No

Sriraj-dev avatar Oct 06 '21 08:10 Sriraj-dev

Can you add screenshots to the PR description as well as in the directory of your app?

Here is how it is done in another app in repo: https://github.com/nisrulz/flutter-examples/tree/develop/covid19_mobile_app

nisrulz avatar Oct 06 '21 09:10 nisrulz

Can you add screenshots to the PR description as well as in the directory of your app?

Here is how it is done in another app in repo: https://github.com/nisrulz/flutter-examples/tree/develop/covid19_mobile_app

Yes, @nisrulz Now, I have added the screenshots and a recording.

Thankyou.

Sriraj-dev avatar Oct 06 '21 09:10 Sriraj-dev

@nisrulz Is there any other issue with this PR?

Sriraj-dev avatar Oct 07 '21 04:10 Sriraj-dev

In the video, few things I noted:

  1. Why do you need the smiley face? If it has no action then please remove it. The app is supposed to be bare minimum implementation.
  2. The news feed has 3D scrolling effect vs the Meme feed is swipe triggered. Would better if they both had the same style. Additionally you should get rid of the 3D scrolling effect and use the normal list scrolling effect. That is much better.
  3. Work on the design of the app a little bit. I did a quick mockup: Artboard-4 (1)

nisrulz avatar Oct 07 '21 08:10 nisrulz

In the video, few things I noted:

  1. Why do you need the smiley face? If it has no action then please remove it. The app is supposed to be bare minimum implementation.
  2. The news feed has 3D scrolling effect vs the Meme feed is swipe triggered. Would better if they both had the same style. Additionally you should get rid of the 3D scrolling effect and use the normal list scrolling effect. That is much better.
  3. Work on the design of the app a little bit. I did a quick mockup: Artboard-4 (1)

Ok, Fine @nisrulz , I have implemented two types of list views just to introduce the 3D-List view and its capability. Fine, will make the changes soon.

Thankyou

Sriraj-dev avatar Oct 07 '21 08:10 Sriraj-dev

Actually the 3D List View can be another example app. The idea is to create the simplest and bare minimum apps in this repo. If you club multiple functionality then it defeats the purpose of the repository.

An individual app like yours should follow uniformity, hence my suggestion. In real world scenarios we don't ship proper apps that do CRUD with different design aesthetics.

nisrulz avatar Oct 07 '21 08:10 nisrulz

@nisrulz now, I have made all the changes mentioned above.

Thankyou.

Sriraj-dev avatar Oct 07 '21 10:10 Sriraj-dev

Any other issues to merge? @nisrulz

Sriraj-dev avatar Oct 09 '21 03:10 Sriraj-dev