Nishanth Shanmugham
Nishanth Shanmugham
Sorry about that. I'm not actively maintaining this repo. Happy to accept a PR that fixes this.
Thanks for the report. This is a late reply, and I sincerely apologize. This change is very useful; I'm happy to accept pull requests for this. I was not actively...
I don't have much experience importing Objective-C into Swift. But this section may help: https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html
I'd incorrectly suggested the `-ignore-enum-members` flag in an earlier (now deleted) comment. I think we should add a similar `-ignore-enum-types` flag for this use case.
(Edited to address "and if many cases are missing" part.) @xiegeo: Does the existing `-default-signifies-exhaustive` flag address your use case, in general? ``` -default-signifies-exhaustive presence of 'default' case in switch...
Commit https://github.com/nishanths/exhaustive/commit/176c4b3f18c94278e08c946227e5f9f13cbd1dbe adds an `-ignore-enum-types` flag. Example usage: ``` exhaustive -ignore-enum-types '^reflect\.Kind$|^time\.Duration$' ``` Closing this issue. Please feel free to reopen if the flag doesn't meet your needs.
+1 for the check. To implement this, it seems that the program would need to visit all AST nodes, not just `SwitchStmt` (switch statements), `CompositeLit` (map literals), and `GenDecl` (enum...
Thanks for the change. It looks good to me overall. I added a few comments.
I added [another test](https://github.com/nishanths/exhaustive/pull/72/commits/499a89c77865de0c96e8d06e6e4690d8a5f2677d) and [a small change](https://github.com/nishanths/exhaustive/pull/72/commits/74821eac10c04583939b729880e7fb40a0d9469b).