crumbsjs icon indicating copy to clipboard operation
crumbsjs copied to clipboard

add standard to lint src code

Open Johann-S opened this issue 5 years ago • 2 comments

Hi @nirtz89,

This PR add standard as a linter, currently it lint only your source code.

Maybe you don't want this linter, so feel free to close this PR 👍

Johann-S avatar Apr 01 '19 12:04 Johann-S

I had actually planned on working on implementing a linter in the near future, albeit, eslint as opposed to standardjs.

standardjs has some rules that conflict heavily with the author's original work. The FAQ also claims many benefits, including "No configuration", "Auto Formatting Code", "Catching style issues & programmer errors early". Any sort of linter should perform the last two points. Not having to submit a config to linter sounds great on paper. However, it's heavily opinionated in many controversial areas, without the ability to disable or override these rules.

Of course the decision lies with the author. I would agree that a linter is a must, just not this linter. If zero config is the goal, extending any popular eslint config allows a quick and easy starting point, with the ability to override as needed.

If this linter is chosen, however, you should include the other .js files in this repo, reformatted, as part of your PR.

swiftmatt avatar Apr 02 '19 00:04 swiftmatt

It's just a proposal 👍

But yes if @nirtz89 aggreed for this linter I'll lint the other JS files 👍

Johann-S avatar Apr 02 '19 07:04 Johann-S