pydra icon indicating copy to clipboard operation
pydra copied to clipboard

Fixes tests after refactor of `fileformats.generic.File` into `BinaryFile` and `UnicodeFile`

Open tclose opened this issue 1 year ago • 1 comments

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Update to the fileformats dependency to add support for static type checking broke a couple of tests (not the code-base itself). This PR fixes those tests.

Checklist

  • [x] I have added tests to cover my changes (if necessary)
  • [x] I have updated documentation (if necessary)

tclose avatar Sep 20 '24 07:09 tclose

@djarecka this is just a minor PR that needs to merged in for the master branch to pass the tests. Do you mind if I do it myself? The only changes are cleaning up some typing and the use of BinaryFile and raw_contents instead of File and contents in a couple of tests

tclose avatar Sep 28 '24 03:09 tclose

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@d674840). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage        ?   89.11%           
=======================================
  Files           ?       55           
  Lines           ?    15789           
  Branches        ?     1379           
=======================================
  Hits            ?    14070           
  Misses          ?     1717           
  Partials        ?        2           
Flag Coverage Δ
unittests 89.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 17 '25 19:03 codecov[bot]