pydra icon indicating copy to clipboard operation
pydra copied to clipboard

Handle None types

Open tclose opened this issue 1 year ago • 2 comments

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

  • Handles None in field types, e.g. int | None instead of typing.Optional[int]

Checklist

  • [x] I have added tests to cover my changes (if necessary)
  • [x] I have updated documentation (if necessary)

added by @ghisvail Closes #744

tclose avatar Mar 25 '24 02:03 tclose

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.71%. Comparing base (e52e32b) to head (a7ac191).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   84.27%   91.71%   +7.43%     
==========================================
  Files          26       55      +29     
  Lines        5127    15681   +10554     
  Branches     1447     2792    +1345     
==========================================
+ Hits         4321    14382   +10061     
- Misses        800     1291     +491     
- Partials        6        8       +2     
Flag Coverage Δ
unittests 91.71% <100.00%> (+7.43%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 02:03 codecov[bot]

I did a superficial read of the diff and what I checked so far looked sensible 👍

ghisvail avatar Apr 03 '24 07:04 ghisvail