pydra icon indicating copy to clipboard operation
pydra copied to clipboard

[wip] adding a part for pandas.df to hash_value

Open djarecka opened this issue 2 years ago • 3 comments

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

adding a section to hash_value that is for pandas.DF: changing df to dict before calculating the hash value.

@yibeichan - could you please see if this small change fixes some of your issues? it did fix the issue that I had with running my workflow within the jupyter notebook...

Checklist

  • [ ] I have added tests to cover my changes (if necessary)
  • [ ] I have updated documentation (if necessary)

djarecka avatar Sep 02 '22 16:09 djarecka

Codecov Report

Base: 77.06% // Head: 77.04% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (875fd17) compared to base (219c721). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   77.06%   77.04%   -0.02%     
==========================================
  Files          20       20              
  Lines        4316     4322       +6     
  Branches     1213     1217       +4     
==========================================
+ Hits         3326     3330       +4     
- Misses        802      803       +1     
- Partials      188      189       +1     
Flag Coverage Δ
unittests 76.95% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/helpers.py 79.52% <0.00%> (-0.38%) :arrow_down:
pydra/engine/core.py 89.04% <0.00%> (+0.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 02 '22 16:09 codecov[bot]

@djarecka thank you! I'll try it today and let you now

yibeichan avatar Sep 02 '22 16:09 yibeichan

@djarecka this change is specific for a list of pandas.Dataframe as inputs, correct? my notebook works fine with or without this change because I'm using python 3.7? If this can solve your problem, then it probably can solve potential problems in higher python as well. However, I exported my notebook as .py and got errors (not related to your change here)

File "/Users/yibeichen/miniconda3/envs/pydra/lib/python3.7/asyncio/futures.py", line 181, in result raise self._exception concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

this error happens after secondlevel_estimation when starting statistical testing. Only .py script has this error, notebook works fine.

yibeichan avatar Sep 03 '22 03:09 yibeichan