changing template formatting when value (or default) is False

[djarecka]

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Summary

when output use template to create the output path and value is False the field should not be used in the cmdline, it was inconsistent

Checklist

• [x] I have added tests to cover my changes (if necessary)
• [ ] I have updated documentation (if necessary)

[codecov[bot]]

Codecov Report

Merging #561 (3fe8f23) into master (ac06f8c) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   77.13%   77.09%   -0.04%     
==========================================
  Files          20       20              
  Lines        4316     4322       +6     
  Branches     1212     1215       +3     
==========================================
+ Hits         3329     3332       +3     
- Misses        799      802       +3     
  Partials      188      188              

Flag	Coverage Δ
unittests	77.00% <100.00%> (-0.04%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pydra/engine/helpers.py	80.00% <100.00%> (-0.62%)	:arrow_down:
pydra/engine/helpers_file.py	78.85% <100.00%> (ø)
pydra/engine/specs.py	88.64% <100.00%> (+0.05%)	:arrow_up:
pydra/engine/task.py	86.85% <100.00%> (+0.08%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[djarecka]

@yibeichan - this is the fix for the template, I was trying this on the example of FNIRT, but you can try on your example if you want and let me know if this makes sense

[yibeichan]

@djarecka thank you! so I create a local branch for pydra, used your code. then run pytest in pydra-fsl on cluster.py, but my task.cmdline still changed after task.run(). Here is my cluster.py https://github.com/yibeichan/pydra-fsl/blob/wip-yc-convert/pydra/tasks/fsl/model/cluster.py; here is the test https://github.com/yibeichan/pydra-fsl/blob/wip-yc-convert/pydra/tasks/fsl/model/tests/test_run_cluster.py

[djarecka]

thanks, I will check your tests